feat: switch to dandydeveloper/redis-ha chart 🚀 #335
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tuunit
force-pushed
the
feat/switch-to-dandydeveloper-redis-ha
branch
3 times, most recently
from
05fcb04 to
1896d9d
Compare
tuunit
changed the title
There was a problem hiding this comment.
Pull Request Overview
This PR switches from the Bitnami Redis chart to the dandydeveloper/redis-ha chart for Redis deployment in oauth2-proxy. This change provides a more suitable Redis High Availability solution while maintaining backwards compatibility for existing configurations.
- Replace Bitnami Redis chart dependency with dandydeveloper/redis-ha chart
- Update configuration structure to match new chart's parameters
- Fix template logic for Redis authentication and connection handling
Reviewed Changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| helm/oauth2-proxy/Chart.yaml | Updates chart version and replaces Redis dependency with redis-ha chart |
| helm/oauth2-proxy/values.yaml | Updates Redis configuration comments and formatting to match new chart structure |
| helm/oauth2-proxy/templates/deployment.yaml | Fixes Redis authentication check logic |
| helm/oauth2-proxy/templates/_helpers.tpl | Updates Redis connection templates for new chart naming conventions |
| helm/oauth2-proxy/ci/*.yaml | Updates CI test configurations to use new Redis chart parameters |
| ct.yaml | Changes chart repository from Bitnami to dandydeveloper |
| .github/workflows/release.yaml | Updates Helm repository configuration for releases |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
tuunit
force-pushed
the
feat/switch-to-dandydeveloper-redis-ha
branch
from
1896d9d to
1e9c2dd
Compare
pierluigilenoci
previously approved these changes
Aug 13, 2025
8 tasks
Signed-off-by: Jan Larwig <[email protected]>
Signed-off-by: Jan Larwig <[email protected]>
tuunit
force-pushed
the
feat/switch-to-dandydeveloper-redis-ha
branch
from
55e4227 to
1d5bef1
Compare
Signed-off-by: Jan Larwig <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the Helm chart for
oauth2-proxyto replace the Bitnami Redis subchart with thedandydeveloper/redis-hachart, updates the chart version, and adjusts related configuration and test files accordingly. The changes ensure compatibility with the new Redis chart and improve clarity in configuration.Redis chart migration and configuration:
dandydeveloper/redis-hachart inChart.yamldependencies and updated the repository references in.github/workflows/release.yamlandct.yaml.values.yamland CI test values files to align withredis-haparameters, including new recommended settings and documentation links.redis-ha, including updates to fullname generation and Redis URL construction.Chart version and metadata updates:
8.0.0inChart.yamland updated the changelog annotation to reflect the Redis chart migration.Alternative to #330
and another solution for #323